-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add open-props topic #4660
base: main
Are you sure you want to change the base?
Add open-props topic #4660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple requests. Thank you.
My change requests have been handled but still failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where the copypasta is from but it should have attribution. Please link to the source of that text with a "(From : )" at the bottom.
Also you included headers from the original page which will not work in this context.
lgtm Co-authored-by: Eric Sorenson <[email protected]> Signed-off-by: srgeneroso <[email protected]>
Please confirm this pull request meets the following requirements:
Which change are you proposing?
Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:
*.png
, square, dimensions 288x288, size <= 75 kB)index.md
)Curating a new topic or collection
https://github.com/topics/[NAME]
orhttps://github.com/collections/[NAME]
)*.png
image (if applicable) andindex.md
index.md
conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docsOpen Props is a very thoughtful and comprehensive design tool that manages to be easy to use, beautiful and fully compatible with any project that uses CSS. It was made by Adam Argyle, who is one of the best advocates for CSS (He is currently working on google for the CSS group for chrome). Please consider this entry as it is the best way I can find to show some love to the project and the awesome community around it.
Something that does not neatly fit into the binary options above
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.